Add filename parameter for bytes-based loading#285
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
williballenthin
force-pushed
the
worktree-issue-16-filename-param
branch
from
feb9713 to
908bdf5
Compare
williballenthin
commented
Mar 10, 2026
mr-tz
requested changes
Mar 24, 2026
Contributor
mr-tz
left a comment
mr-tz
left a comment
There was a problem hiding this comment.
LGTM besides the highlighted tests
Allow users to specify a custom filename when loading modules or shellcode from bytes. This is useful when malware checks its own filename (e.g. via GetModuleFileName). Closes #16
williballenthin
force-pushed
the
worktree-issue-16-filename-param
branch
from
908bdf5 to
748fe53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filenameparameter toSpeakeasy.load_module()andSpeakeasy.load_shellcode()(and their internal implementations inWin32EmulatorandWinKernelEmulator)ntpath.basename()Usage
Closes #16
Test plan
test_load_module_filename_override— bytes + filename sets correct file_name/mod_nametest_load_module_filename_strips_directory— Windows paths are basename-strippedtest_load_module_path_still_works— path-only loading unchangedtest_load_module_filename_overrides_path— filename takes precedence over pathtest_load_module_kernel_filename_override— kernel driver loading with filename🤖 Generated with Claude Code